Add CppCompat.ULong32, CppCompat.LongLong64 and CppCompat.ULongLong64
#6386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ong64` This extends carbon-language#6364 to allow having: * `Cpp.unsigned_long` as a distinct type when `unsigned long` is 32 bits. * `Cpp.long_long` and `Cpp.unsigned_long_long` as distinct types when `long` and `unsigned long` are 64 bits. Similarly to carbon-language#6364, we only support implicit conversions from the matching literal type (`u32`, `i64` and `u64`). See carbon-language#6275 for rationale. Part of carbon-language#5263.
geoffromer
reviewed
Nov 18, 2025
Contributor
geoffromer
left a comment
geoffromer
left a comment
There was a problem hiding this comment.
Are these types supported in lowering? If so, should there be tests for that?
| } | ||
|
|
||
| // TODO: ImplicitAs from ULong32 to UInt(N) if N > 32. | ||
| final impl CppCompat.ULong32 as ImplicitAs(u32) { |
Contributor
There was a problem hiding this comment.
Optional: I think I'd find it a little clearer to group the conversions for the same type together (e.g. group this together with u32 as ImplicitAs(CppCompat.ULong32)), rather than grouping the conversions by whether they're to or from a CppCompat type.
| unsigned int carbon_width, | ||
| llvm::StringRef cpp_compat_name) | ||
| -> TypeExpr { | ||
| if (cpp_width != carbon_width) { |
Contributor
There was a problem hiding this comment.
Are there cases where you expect this to happen, and it's not a bug in the toolchain?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends #6364 to allow having:
Cpp.unsigned_longas a distinct type whenunsigned longis 32 bits.Cpp.long_longandCpp.unsigned_long_longas distinct types whenlongandunsigned longare 64 bits.Similarly to #6364, we only support implicit conversions from the matching literal type (
u32,i64andu64).See #6275 for rationale.
Part of #5263.